-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blog section with summary display on listing page #9
base: main
Are you sure you want to change the base?
Conversation
…ent/blog/_index.md to define the blog section. :: Added two sample blog post content/blog/second.md and content/blog/first.md with Lorem Ipsum text. :: Updated layouts/blog/list.html to display only the summary of each blog post in the listing. :: Added <more--> tag in second.md to define the summary cutoff point. :: Set summaryLength parameter in config.toml to control the length of automatically generated summaries.
I'm not sure the purpose of this PR, it doesn't seem to add any content relevant to snapcrafters, and we haven't discussed publicizing a blog? I'm going to close this for now, but please feel free to come and chat with us on Matrix: https://matrix.to/#/#snapcrafters:matrix.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, these initial HTML implementation looks good. But do the changes requested. Also, please fix the PR description, use backticks "`" when you need to write a code block. And rewrite the PR description properly in a List style.
Okay - now I understand. There is pretty minimal boilerplate in here, so I suggest we just add the structure when we publish the first post. A single PR with two commits:
|
Okay - from a structure perspective I think this is good to merge, but let's wait to merge it until we've added the first blog post, too. That way we don't have a totally empty blog page 🙂 |
Actually -- looks like there are some alignment issues. If you take a look at the |
Till now I completed the structural part of the blog and now I will work on styling the pages, please review the changes that I made till now. @soumyaDghosh |
Completed the styling of the blog site, please review @soumyaDghosh |
@jnsgruk As much I tested. I think this PR is ready to merge. If you have any suggestions, please let us know. |
Some screenshots, looking great! 🎉 Thanks a lot @bits-and-atoms! |
Added a new section for blogs.