Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog section with summary display on listing page #9

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

bits-and-atoms
Copy link

@bits-and-atoms bits-and-atoms commented Jan 29, 2025

Added a new section for blogs.

…ent/blog/_index.md to define the blog section. :: Added two sample blog post content/blog/second.md and content/blog/first.md with Lorem Ipsum text. :: Updated layouts/blog/list.html to display only the summary of each blog post in the listing. :: Added <more--> tag in second.md to define the summary cutoff point. :: Set summaryLength parameter in config.toml to control the length of automatically generated summaries.
@jnsgruk
Copy link
Member

jnsgruk commented Jan 30, 2025

I'm not sure the purpose of this PR, it doesn't seem to add any content relevant to snapcrafters, and we haven't discussed publicizing a blog? I'm going to close this for now, but please feel free to come and chat with us on Matrix: https://matrix.to/#/#snapcrafters:matrix.org

@jnsgruk jnsgruk closed this Jan 30, 2025
@soumyaDghosh soumyaDghosh reopened this Jan 30, 2025
Copy link
Member

@soumyaDghosh soumyaDghosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, these initial HTML implementation looks good. But do the changes requested. Also, please fix the PR description, use backticks "`" when you need to write a code block. And rewrite the PR description properly in a List style.

@jnsgruk
Copy link
Member

jnsgruk commented Jan 31, 2025

Okay - now I understand. There is pretty minimal boilerplate in here, so I suggest we just add the structure when we publish the first post. A single PR with two commits:

  • One that makes the structure changes required (per this PR)
  • Another commit that adds the first (actual) blog post

@jnsgruk
Copy link
Member

jnsgruk commented Feb 3, 2025

Okay - from a structure perspective I think this is good to merge, but let's wait to merge it until we've added the first blog post, too. That way we don't have a totally empty blog page 🙂

@jnsgruk
Copy link
Member

jnsgruk commented Feb 3, 2025

Actually -- looks like there are some alignment issues. If you take a look at the snap-packages layout, you'll see that we include a <div class="row"> that wraps the content. We need to continue to use the tools provided by the Vanilla Framework to ensure the page continues to be responsive and accessible across different device types :)

image

@bits-and-atoms
Copy link
Author

Till now I completed the structural part of the blog and now I will work on styling the pages, please review the changes that I made till now. @soumyaDghosh

@bits-and-atoms
Copy link
Author

Completed the styling of the blog site, please review @soumyaDghosh

@soumyaDghosh soumyaDghosh requested a review from jnsgruk February 28, 2025 20:40
@soumyaDghosh
Copy link
Member

@jnsgruk As much I tested. I think this PR is ready to merge. If you have any suggestions, please let us know.

@soumyaDghosh
Copy link
Member

image

Some screenshots, looking great! 🎉

Thanks a lot @bits-and-atoms!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants