Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add wildcard certificate check and fix service port issue #14

Merged
merged 2 commits into from
Nov 21, 2023
Merged

refactor: add wildcard certificate check and fix service port issue #14

merged 2 commits into from
Nov 21, 2023

Conversation

ssttehrani
Copy link
Contributor

This commit involves two changes:

  1. Wildcard Certificate Check: The update introduces a mechanism to inspect each custom certificate. If a certificate is identified as a wildcard certificate, the system is configured to utilize HTTP/1.1. Conversely, if the certificate is not a wildcard, both HTTP/1.1 and HTTP/2 (h2) protocols are enabled in the Contour HTTPProxy object.
  2. Service Port Issue Fix: The commit also addresses a bug related to Route targetPort. Previously, targetPort was checked against a list of service ports. This update corrects the issue by ensuring that the targetPort is now checked against the endpoints port list, which is the appropriate reference for this operation.

@ssttehrani ssttehrani self-assigned this Nov 21, 2023
@ssttehrani ssttehrani merged commit abc9afa into snapp-incubator:main Nov 21, 2023
2 checks passed
@ssttehrani ssttehrani deleted the refactor/wildcard-certs-and-svc-ports branch November 21, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealak12 therealak12 therealak12 approved these changes

Assignees

@ssttehrani ssttehrani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssttehrani @therealak12