Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added helm releasing workflow #10

Merged
merged 2 commits into from
Dec 6, 2023
Merged

added helm releasing workflow #10

merged 2 commits into from
Dec 6, 2023

Conversation

sinamna
Copy link
Collaborator

@sinamna sinamna commented Dec 4, 2023

Summary by CodeRabbit

  • New Features

    • Introduced automated Helm chart releases through GitHub Actions.
    • Implemented a new helmify target in the Makefile for enhanced build processes.
  • Refactor

    • Renamed chart entities to "simple-authenticator" for clarity and consistency in Kubernetes templates.
  • Chores

    • Updated GitHub Actions workflows to include new jobs and an environment variable for operator SDK versioning.
    • Structured changelog categories in the release workflow for better release note organization.

Copy link

coderabbitai bot commented Dec 4, 2023

Walkthrough

The project has undergone a CI/CD pipeline enhancement, focusing on Helm chart releases and Docker image builds. New GitHub Actions workflows have been introduced for Helm chart release automation and structured changelog generation. Additionally, the Makefile and Helm chart templates have been updated, renaming entities to align with the "simple-authenticator" nomenclature, reflecting a more specific and standardized naming convention.

Changes

File Path Change Summary
.github/workflows/release.yaml Added GitHub Actions workflow for Helm chart release
Makefile Added helmify target; updated helm target to include helmify
deploy/charts/.../_helpers.tpl
charts/simple-authenticator/.../_helpers.tpl
Renamed chart-related entities to "simple-authenticator"
.github/release.yaml Introduced structured changelog categories
.github/workflows/build-release.yaml Renamed job, added OPERATOR_SDK_VERSION, and introduced new jobs

🐇
In the burrow of code, the changes do hop,
Helm charts and workflows, they never do stop.
With each push and pull, the CI does cheer,
"Simple-authenticator," the name we hold dear. 🎉


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@sinamna sinamna requested a review from hoptical December 4, 2023 15:32
@sinamna sinamna self-assigned this Dec 4, 2023
@sinamna sinamna added the enhancement New feature or request label Dec 4, 2023
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 68356b5 and 7cb2a4f.
Files ignored due to filter (17)
  • chart/templates/selfsigned-issuer.yaml
  • chart/templates/serving-cert.yaml
  • deploy/charts/simple-authenticator/Chart.yaml
  • deploy/charts/simple-authenticator/templates/basicauthenticator-crd.yaml
  • deploy/charts/simple-authenticator/templates/deployment.yaml
  • deploy/charts/simple-authenticator/templates/leader-election-rbac.yaml
  • deploy/charts/simple-authenticator/templates/manager-rbac.yaml
  • deploy/charts/simple-authenticator/templates/metrics-reader-rbac.yaml
  • deploy/charts/simple-authenticator/templates/metrics-service.yaml
  • deploy/charts/simple-authenticator/templates/mutating-webhook-configuration.yaml
  • deploy/charts/simple-authenticator/templates/proxy-rbac.yaml
  • deploy/charts/simple-authenticator/templates/selfsigned-issuer.yaml
  • deploy/charts/simple-authenticator/templates/serviceaccount.yaml
  • deploy/charts/simple-authenticator/templates/serving-cert.yaml
  • deploy/charts/simple-authenticator/templates/validating-webhook-configuration.yaml
  • deploy/charts/simple-authenticator/templates/webhook-service.yaml
  • deploy/charts/simple-authenticator/values.yaml
Files selected for processing (3)
  • .github/workflows/release.yaml (1 hunks)
  • Makefile (1 hunks)
  • deploy/charts/simple-authenticator/templates/_helpers.tpl (4 hunks)
Additional comments: 2
.github/workflows/release.yaml (1)
  • 1-31: > 💡 NOTE

Codebase verification is a beta feature.

The charts_dir path deploy/charts is confirmed to exist within the project's directory structure. The workflow setup for releasing a Helm chart is correct and should function as expected when triggered.

deploy/charts/simple-authenticator/templates/_helpers.tpl (1)
  • 45-61: > 💡 NOTE

Codebase verification is a beta feature.

The changes in the Helm chart templates from "chart" to "simple-authenticator" are consistent with the PR objectives and the summary provided. The search for old template references in .tpl files yielded no results, indicating that there are no outdated references to the renamed templates within the Helm chart templates.

Makefile Show resolved Hide resolved
Copy link
Collaborator

@hoptical hoptical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please:

  1. change the workflow according the s3-operator's one.
  2. move the deploy/charts/simple-authenticator to charts/simple-authenticator.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7cb2a4f and e01df47.
Files ignored due to filter (15)
  • charts/simple-authenticator/Chart.yaml
  • charts/simple-authenticator/templates/basicauthenticator-crd.yaml
  • charts/simple-authenticator/templates/deployment.yaml
  • charts/simple-authenticator/templates/leader-election-rbac.yaml
  • charts/simple-authenticator/templates/manager-rbac.yaml
  • charts/simple-authenticator/templates/metrics-reader-rbac.yaml
  • charts/simple-authenticator/templates/metrics-service.yaml
  • charts/simple-authenticator/templates/mutating-webhook-configuration.yaml
  • charts/simple-authenticator/templates/proxy-rbac.yaml
  • charts/simple-authenticator/templates/selfsigned-issuer.yaml
  • charts/simple-authenticator/templates/serviceaccount.yaml
  • charts/simple-authenticator/templates/serving-cert.yaml
  • charts/simple-authenticator/templates/validating-webhook-configuration.yaml
  • charts/simple-authenticator/templates/webhook-service.yaml
  • charts/simple-authenticator/values.yaml
Files selected for processing (3)
  • .github/release.yaml (1 hunks)
  • .github/workflows/build-release.yaml (2 hunks)
  • charts/simple-authenticator/templates/_helpers.tpl (4 hunks)
Files skipped from review due to trivial changes (1)
  • .github/release.yaml
Additional comments: 7
.github/workflows/build-release.yaml (3)
  • 9-16: The job docker has been successfully renamed to build-push-operator, and the OPERATOR_SDK_VERSION environment variable has been added as described in the summary.

  • 50-78: The new jobs helm-chart and release have been added as outlined in the summary, expanding the workflow's responsibilities.

  • 37-78: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [1-78]

The summary mentions the addition of a .github/workflows/release.yaml file, but this file is not present in the provided hunks. Please ensure that this file has been added as intended or update the summary accordingly.

charts/simple-authenticator/templates/_helpers.tpl (4)
  • 1-6: The renaming of the Helm chart entities from "chart" to "simple-authenticator" in the name template is consistent with the PR objectives and summary.

  • 10-16: The renaming of the Helm chart entities from "chart" to "simple-authenticator" in the fullname template is consistent with the PR objectives and summary.

  • 26-41: The renaming of the Helm chart entities from "chart" to "simple-authenticator" in the chart and labels templates is consistent with the PR objectives and summary.

  • 45-61: The renaming of the Helm chart entities from "chart" to "simple-authenticator" in the selectorLabels and serviceAccountName templates is consistent with the PR objectives and summary.

@sinamna sinamna merged commit e258e79 into main Dec 6, 2023
1 check passed
@sinamna sinamna deleted the release-workflow branch December 11, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants