-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement admin authenticator #5
Conversation
@mohammadiahmad @mehditeymorian code is not finished yet but if you can tell about your opinions on this, it would be great. |
Codecov Report
@@ Coverage Diff @@
## main #5 +/- ##
==========================================
+ Coverage 17.00% 24.51% +7.50%
==========================================
Files 10 11 +1
Lines 682 722 +40
==========================================
+ Hits 116 177 +61
+ Misses 563 531 -32
- Partials 3 14 +11
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
// ACL check a system user access to a topic. | ||
// because we returns is-admin: true, this endpoint shouldn't | ||
// be called. | ||
func (a AdminAuthenticator) ACL( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@1995parham In long term view we can think about restricting services on their topics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right Ahmad jan, EMQ has a concept which creates tenants for you by prefixing topics. We can use this feature for supporting different vendors but right now we need shared topics. For example Snapp Box want to read the Snapp events this means we need to validate Snapp Box tokens for Snapp topics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems well put together.🔥
…ication Implement admin authenticator
Admin authenticator will provides superuser access for its company users. It uses the same tenant concept in Soteria as other authenticators.