[plearn] Add plearn strategy #1357
Conversation
src/strategies/plearn/index.ts
Outdated
| options.lockedPoolAddresses.map((item) => | ||
| multicall( | ||
| network, | ||
| provider, | ||
| lockedPoolabi, | ||
| addresses.map((address: any) => [ | ||
| item.address, | ||
| 'userInfo', | ||
| [address], | ||
| { blockTag } | ||
| ]), | ||
| { blockTag } | ||
| ) | ||
| ) | ||
| ); |
There was a problem hiding this comment.
Is it possible to limit the number of lockedPoolAddresses foundingInvestorPoolAddresses, pendingWithdrawalAddresses and make sure number of requests doesn't cross 5 https://github.com/snapshot-labs/snapshot-strategies#code
There was a problem hiding this comment.
@ChaituVR
I've implemented the changes as you suggested. Now, I've limited the arrays for lockedPoolAddresses, foundingInvestorPoolAddresses, and pendingWithdrawalAddresses to have no more than 5 addresses each. Thanks
There was a problem hiding this comment.
But that will max 15 network calls, we can only allow upto max 5 network calls https://github.com/snapshot-labs/snapshot-strategies#code
There was a problem hiding this comment.
@ChaituVR I've updated code, could you please take another look at it?
Tiakun refactor 1
Refactor code
|
@jeeraponnnnnnnn could you resolve conflicts please :) |
Changes proposed in this pull request: