Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hats-protocol-hat-id] Fix hats-protocol-hat-id strategy #1367

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

gershido
Copy link
Contributor

@gershido gershido commented Dec 1, 2023

Fixes hats-protocol-hat-id strategy.

Changes proposed in this pull request:

  • Fix hat ID conversion
  • Remove subgraph usage
  • Use a multi-call to get the wearers of the hat

@ChaituVR ChaituVR changed the title Fix hats-protocol-hat-id strategy [hats-protocol-hat-id] Fix hats-protocol-hat-id strategy Dec 2, 2023
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gershido PR should be coming from hotmanics as they are the author

src/strategies/hats-protocol-hat-id/index.ts Show resolved Hide resolved
@JacobHomanics
Copy link
Contributor

Hi @gershido PR should be coming from hotmanics as they are the author

Hey @ChaituVR. We decided to let @gershido do the PR as he was the one that ultimately found and fixed the bug, so just wan't to give him credit where its due. Is it possible for him to follow through on this? Otherwise I'm sure I can just make the changes and a PR from my account.

@ChaituVR ChaituVR merged commit b68c291 into snapshot-labs:master Dec 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants