Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use customFetch instead of fetch #1600

Merged
merged 5 commits into from
Oct 5, 2024

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Oct 4, 2024

Closes https://github.com/snapshot-labs/workflow/issues/236

We already have an existing helper fetch function, supporting timeout

This PR replaces all direct calls to fetch from the cross-fetch lib, to our custom fetch helper, to take advantage of the timeout feature.

Now, all fetch calls from score-api have a max timeout of 20s

@wa0x6e wa0x6e requested a review from ChaituVR October 4, 2024 21:45
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@ChaituVR ChaituVR merged commit 491c062 into master Oct 5, 2024
5 checks passed
@ChaituVR ChaituVR deleted the use-custom-fetch-for-all-fetch-requests branch October 5, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants