Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pagination strategy from strategies #885

Closed
wants to merge 1 commit into from

Conversation

emnul
Copy link
Contributor

@emnul emnul commented Oct 13, 2022

Fixes #834 .

Changes proposed in this pull request:

  • Remove pagination from strategies
  • Import pagination code from snapshot-labs/score-api
  • Add score-api repo as a dependency

Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes don't make sense to me, These changes work in your local?
i see Cannot find module '@snapshot-labs/score-api' or its corresponding type declarations.

There is not much in the original issue description but ideally, it should be like this:

  • Make it impossible to select this strategy in space settings on UI and hub
    as mentioned here Deprecate strategy "multichain" #688
  • Once we do the announcement about this, we can remove this strategy

@emnul
Copy link
Contributor Author

emnul commented Oct 13, 2022

Ah okay that makes much more sense when you put it that way. I'll refactor my changes accordingly.

@emnul
Copy link
Contributor Author

emnul commented Oct 14, 2022

PR snapshot-labs/snapshot-v1#3229 removes the pagination strategy from the UI. Technically someone can still update their space strategy setting by calling the hub api, but I feel like removing the strategy from the UI is sufficient enough. I would like to hear your thoughts.

@emnul emnul closed this Oct 22, 2022
@emnul emnul deleted the deprecate-paginationn branch October 22, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate strategy "pagination"
2 participants