Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove Hal plugin #4858

Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix: Remove Hal plugin #4858

merged 1 commit into from
Aug 21, 2024

Conversation

ChaituVR
Copy link
Member

@ChaituVR ChaituVR commented Aug 21, 2024 •
edited
Loading

Summary

Remove hal plugin as it is deprecated

How to test

  1. go to http://localhost:8080/#/stgdao.eth/proposal/0x38d9496b04f51a376a2c4979dea6c499edd5c335e98aed0e05f4070c2a7d5c5d
  2. you should not see hal plugin anymore
  3. In your space settings, you should not see this plugin in plugins list

@ChaituVR ChaituVR requested a review from wa0x6e August 21, 2024 10:37
bonustrack
bonustrack approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ChaituVR ChaituVR merged commit 28028bd into master Aug 21, 2024
5 checks passed
@ChaituVR ChaituVR deleted the remove-hal-plugin branch August 21, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonustrack bonustrack bonustrack approved these changes

@wa0x6e wa0x6e Awaiting requested review from wa0x6e

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChaituVR @bonustrack