Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix search request not being resolved in order #4896

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

wa0x6e
Copy link
Collaborator

@wa0x6e wa0x6e commented Sep 29, 2024

Summary

Trying to fix issue pointed out in https://jam.dev/c/cb4b5003-3dd9-4156-9ccb-dc4a5ac2fc36

When typing letters quickly in the search box, some requests are shown as "no results" wrongly.

This is somewhat hard to reproduce, this PR fix this by making the search sync, so any slow requests will not override latest results.

How to test

  1. Go to http://localhost:8080/#/test.wa0x6e.eth/delegates?search=fabien.eth
  2. It should load the card for the searched ENS name
  3. Try typing something else in the searchbox quickly
  4. It should load the results for the searched name

Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@wa0x6e wa0x6e merged commit cbebadb into master Sep 30, 2024
5 checks passed
@wa0x6e wa0x6e deleted the fix-search-request-async branch September 30, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants