Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix missing on property in test workflow #4899

Merged
merged 2 commits into from
Sep 30, 2024
Merged

ci: fix missing on property in test workflow #4899

merged 2 commits into from
Sep 30, 2024

Conversation

wa0x6e
Copy link
Collaborator

@wa0x6e wa0x6e commented Sep 30, 2024 •
edited
Loading

Summary

This PR fix the failing test workflow, which now required on to be defined explicitly

How to tests

  • On this PR, all github actions are passing

@wa0x6e wa0x6e changed the title ci: fix missing on property in test workflow ci: fix missing on property in test workflow Sep 30, 2024
@wa0x6e wa0x6e requested a review from ChaituVR September 30, 2024 08:30
ChaituVR
ChaituVR approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@wa0x6e wa0x6e merged commit c991c31 into master Sep 30, 2024
6 checks passed
@wa0x6e wa0x6e deleted the chore-fix-missing-on-in-github-workflow branch September 30, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaituVR ChaituVR ChaituVR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wa0x6e @ChaituVR