Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: read execution_strategy from event directly #556

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

Sekhmet
Copy link
Member

@Sekhmet Sekhmet commented Jul 29, 2024

Summary

It's stored directly in the event, not under proposal.

Closes: #503

How to test

  1. Ideally test with fix: restore preloaded block on error checkpoint-labs/checkpoint#312 (so easily notice if it breaks or not).
  2. If you want modify SN_MAIN startBlock to 652679 to speed up testing.
  3. Run NETWORK_NODE_URL=https://starknet-mainnet.infura.io/v3/XXX NETWORK=SN_MAIN yarn dev.
  4. No more error, indexing doesn't get stuck (if testing using that Checkpoint's PR).

It's stored directly in the event, not under proposal.
@Sekhmet Sekhmet added the bug Something isn't working label Jul 29, 2024
@Sekhmet Sekhmet requested a review from bonustrack July 29, 2024 21:41
@Sekhmet Sekhmet merged commit afaa0bf into master Aug 7, 2024
3 checks passed
@Sekhmet Sekhmet deleted the sekhmet/update-proposal branch August 7, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: proposal update is blocking indexing
2 participants