feat: add getDataByMessageHash data endpoint #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pscott
force-pushed
the
feat_add_get_hash_data_endpoint
branch
2 times, most recently
from
413b273
to
87d6d39
Compare
Sekhmet
reviewed
Nov 4, 2024
Sekhmet
reviewed
Nov 4, 2024
| @@ -223,7 +223,7 @@ export class EthereumTx { | |||
|
|
|||
| async estimateProposeFee(signer: Signer, data: Propose) { | |||
| const address = await signer.getAddress(); | |||
| const hash = await this.getProposeHash(signer, data); | |||
| const hash = await this.getProposeHash(address, data); | |||
There was a problem hiding this comment.
Can we extract those sx.js changes to separate PR? With yarn changeset to generate changelog for it.
pscott
force-pushed
the
feat_add_get_hash_data_endpoint
branch
from
98ef193
to
996351d
Compare
pscott
force-pushed
the
feat_add_get_hash_data_endpoint
branch
from
996351d
to
689a1cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
getDataByMessageHashmethod that accepts ahashas params and returns all the information required for the user to re-compute his hash independently.sx.jsin order for thegetProposeHash / getVoteHash / getUpdateProposalHashmethods to accept anaddressinstead of aSigner(required for thehash-verifierto work). Also upgrades the corresponding tests.Closes: #949
How to test
yarn linkto link with the hash-verifier script.Question: is
getDataByMessageHasha proper name? Should we find a better name?