Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add votes page #765

Merged
merged 21 commits into from
Oct 22, 2023
Merged

feat: add votes page #765

merged 21 commits into from
Oct 22, 2023

Conversation

Sekhmet
Copy link
Member

@Sekhmet Sekhmet commented Oct 2, 2023 •
edited
Loading

Closes: #724
Closes: #607

Test plan

  • Use different sorting/filters.

Screenshots

image

@Sekhmet Sekhmet self-assigned this Oct 2, 2023
@bonustrack
Copy link
Member

Layout doesn't looks great atm (my fault) could we move to something like this for the overview page:

image
  • Using the "Overview | Votes" nav as first element of the page
  • Keep title of the proposal how it was previously
  • Move author and space name under title of the proposal

For the votes page I suggest to:

  • Add label for column, and sorting for Date and Voting power. If the sorting is active the label and icon should be white. If the sorting is not active we shouldn't show the icon.
  • Add 3 dots icon in the end of the line, this open a dropdown with a link "View on block explorer"
  • Use only 1 line per item (we can remove the % of vp for now)
image

I created this proposal with a bunch of vote to test:
http://localhost:8080/#/gor:0x21e0a186e708094859c064b656037ebbbd61f57b/proposal/2/votes

Also can we merge this to #760 and continue with a single PR?

@Sekhmet Sekhmet mentioned this pull request Oct 4, 2023
Closed
@Sekhmet Sekhmet changed the base branch from sekhmet/back-button to master October 4, 2023 13:31
samuveth
samuveth reviewed Oct 6, 2023
View reviewed changes
src/views/Proposal/Votes.vue Outdated Show resolved Hide resolved
src/views/Proposal/Votes.vue Outdated Show resolved Hide resolved
src/views/Proposal/Votes.vue Outdated Show resolved Hide resolved
src/networks/common/graphqlApi/index.ts Show resolved Hide resolved
@samuveth
Copy link
Contributor

samuveth commented Oct 9, 2023

By the way, why was the back button removed even though the issue #760 is closed and links to this PR?

@Sekhmet
Copy link
Member Author

Sekhmet commented Oct 9, 2023

@samuveth it's no longer a back button as it didn't fit the design, it's now clickable Space name under proposal title that can take you back.

samuveth
samuveth approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@samuveth samuveth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Left a few more comments for consideration

src/components/Ui/Select.vue Show resolved Hide resolved
src/components/Ui/Select.vue Show resolved Hide resolved
src/components/Ui/Select.vue Outdated Show resolved Hide resolved
@bonustrack
Copy link
Member

Sorry for the back and forth but here is the final design for the votes page: https://www.figma.com/proto/Q7y6LYRDtdJrMPYN0qkYKX/Snapshot%3A-votes-page?type=design&node-id=565-20912&t=H1UHRN7XsoT0zaUU-1&scaling=scale-down-width&page-id=419%3A12100&mode=design
You will need to click on top left icon to see comments, I added few of them to give more details

@bonustrack
Copy link
Member

bonustrack commented Oct 20, 2023 •
edited
Loading

Looks great! Just some few details:

  • "Voting Power" should be "Voting power"
  • Against and abstain icons should be same as in the app with the cross and arrow (this was misleading in my Figma I didn't had the icons so I used approve icon)
  • The choice icons should be aligned to "Choice" column label and all align to left in the column.
  • Ideally the whole column "Date", "Choice" and "Voting power" should be clickable
  • The choice circle icons should be same height and width than on the overview or proposal page, 40px size, not 48px.
  • And the last column with 3 dots should be 60px
  • Choices in the dropdown shouldnt be bold:
image

@bonustrack
Copy link
Member

Also we lost border on modals:
image
Can we have them back?

bonustrack
bonustrack approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@Sekhmet Sekhmet merged commit 08f87df into master Oct 22, 2023
4 checks passed
@Sekhmet Sekhmet deleted the sekhmet/votes branch October 22, 2023 16:44
Sekhmet added a commit to snapshot-labs/sx-monorepo that referenced this pull request Feb 6, 2024
@Sekhmet
feat: add votes page (snapshot-labs/sx-ui#765)
791a706 
* feat: add back button to proposal page

* feat: add votes page

* fix: use decimals for VP display

* refactor: make UiSelect generic

* feat: move space link to Overview

* feat: use table display for votes

* feat: move sort to table headers

* fix: center no results message

* feat: update sortable labels styles

* refactor: use shorter :class notation

* feat: update table header style

* feat: update item styles

* feat: add Copy voter address entry

* feat: make headers sticky

* fix: update voting power spacing

* chore: update VP title

* chore: update choice display

* chore: update last column display

* fix: do not make choices bold

* fix: make entire column cickable

* fix: update border-color variable usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuveth samuveth samuveth approved these changes

@bonustrack bonustrack bonustrack approved these changes

Assignees

@Sekhmet Sekhmet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: votes page feat: add link to the space from the proposal page
3 participants
@Sekhmet @bonustrack @samuveth