Fixes on New-SnipeItUser #303
Open
+100
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs correction
Rebased Fix/jorips1 orginal PR New/Set licenses Removed Validate Length from New-SnipeitLicense -license_email, bringing it in line with Set. This was causing the parameter to fail as it cannot validate the mailaddress object. Added code to convert -license_email to string, as required by the SnipeitAPI. Added -purchase_order functionality. New Supplier Fixed typo in API which was causing the command to fail.
…t if password is less than 8 chars
|
Hi, thanks for fixes. I'm happy to merge this. Could you please change to little things. rebase you changes agains current delvelop branch and change this PR to reference develop instead master. Rebasing will keep changelog tidy by removind all unneeded commits from PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
There were some minor issues in New-SnipeitUser that I fixed:
Have a good one
Frank