Remove EXPOSE_HEADER option #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some tests still fail 😊 I'd also love some docs on how to configure CORS😊 |
|
@JonasKs think that's alright now and have added the CORS documentation. I've had a look at failing tests and seems to be unrelated - they're currently failing to get past the install stage due to this: Any ideas? |
|
Thanks for the PR 😊 Huh, weird. I'll have to look, but I'm away for a week or so now. |
|
@JonasKs no worries at all. Give me a ping if you need me to try anything when you’re back :) |
|
I think this looks good 👍 Added a few things that'd be nice to implement before a major bump in #86, but some might be outdated and some might not be necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match functionality from https://github.com/snok/asgi-correlation-id and remove EXPOSE_HEADER