-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for injector library #176
Conversation
I like the staff you implemented in this linter; we found it useful in our projects. We faced a conflict with the injector project because it used typing annotation in runtime. For example:
In this pull request I want to add the support for such functionality for ones using this library as we do. |
9834b1d
to
aed5627
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Haven't really used this personally, so will trust that this is sufficient for support. Spotted one typo, but the rest looks solid 👍
tests/conftest.py
Outdated
@@ -40,6 +40,7 @@ def _get_error(example: str, *, error_code_filter: Optional[str] = None, **kwarg | |||
mock_options.type_checking_fastapi_enabled = False | |||
mock_options.type_checking_fastapi_dependency_support_enabled = False | |||
mock_options.type_checking_pydantic_enabled_baseclass_passlist = [] | |||
mock_options.type_checking_injector_enables = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be a typo here. Does that mean this isn't needed?
mock_options.type_checking_injector_enables = False | |
mock_options.type_checking_injector_enabled = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The typo is fixed and squashed into a single commit.
aed5627
to
e1a2fdf
Compare
e1a2fdf
to
0db6120
Compare
Code has been rebased onto the current |
Thanks @OlehChyhyryn! |
support for injector library, which is often used in Python for dependency injection pattern implementation