Skip to content

Commit

Permalink
Merge pull request #47 from fuero/feat/fixes-docs
Browse files Browse the repository at this point in the history
Adds clarification to docs, fixes typo, uses correct selector
  • Loading branch information
cmoulliard authored May 7, 2024
2 parents 7410b0f + 5f8c697 commit 60ed3d2
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,11 @@ When the cert-manager has been installed, deploy the helm chart on your machine
export DOMAIN=acme.mydomain.com # replace with your domain
helm install -n cert-manager godaddy-webhook ./deploy/charts/godaddy-webhook --set groupName=$DOMAIN
```

The `groupName` refers to a prior nonexistant Kubernetes API Group, under which custom resources are created.
The name itself has no connection to the domain names for which certificates are issued, and using the default of
`acme.mycompany.com` is fine.

**NOTE**: The kubernetes resources used to install the Webhook should be deployed within the same namespace as the cert-manager.

- To change one of the values, create a `my-values.yml` file or set the value(s) using helm's `--set` argument:
Expand Down Expand Up @@ -122,7 +127,7 @@ kubectl apply -f secret.yml -n <NAMESPACE>

### ClusterIssuer

- Create a `ClusterIssuer`resource to specify the address of the ACME staging or production server to access.
- Create a `ClusterIssuer` resource to specify the address of the ACME staging or production server to access.
Add the DNS01 Solver Config that this webhook will use to communicate with the API of the Godaddy Server in order to create
or delete an ACME Challenge TXT record that the DNS Provider will accept/refuse if the domain name exists.

Expand All @@ -144,8 +149,8 @@ spec:
name: letsencrypt-<ENV> # staging or production
solvers:
- selector:
dnsNames:
- '*.example.com'
dnsZones:
- 'example.com'
dns01:
webhook:
config:
Expand Down

0 comments on commit 60ed3d2

Please sign in to comment.