Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds clarification to docs, fixes typo, uses correct selector #47

Merged
merged 1 commit into from
May 7, 2024
Merged

Adds clarification to docs, fixes typo, uses correct selector #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,11 @@ When the cert-manager has been installed, deploy the helm chart on your machine
export DOMAIN=acme.mydomain.com # replace with your domain
helm install -n cert-manager godaddy-webhook ./deploy/charts/godaddy-webhook --set groupName=$DOMAIN
```

The `groupName` refers to a prior nonexistant Kubernetes API Group, under which custom resources are created.
The name itself has no connection to the domain names for which certificates are issued, and using the default of
`acme.mycompany.com` is fine.

**NOTE**: The kubernetes resources used to install the Webhook should be deployed within the same namespace as the cert-manager.

- To change one of the values, create a `my-values.yml` file or set the value(s) using helm's `--set` argument:
Expand Down Expand Up @@ -122,7 +127,7 @@ kubectl apply -f secret.yml -n <NAMESPACE>

### ClusterIssuer

- Create a `ClusterIssuer`resource to specify the address of the ACME staging or production server to access.
- Create a `ClusterIssuer` resource to specify the address of the ACME staging or production server to access.
Add the DNS01 Solver Config that this webhook will use to communicate with the API of the Godaddy Server in order to create
or delete an ACME Challenge TXT record that the DNS Provider will accept/refuse if the domain name exists.

Expand All @@ -144,8 +149,8 @@ spec:
name: letsencrypt-<ENV> # staging or production
solvers:
- selector:
dnsNames:
- '*.example.com'
dnsZones:
- 'example.com'
dns01:
webhook:
config:
Expand Down
Loading