Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #53 Equal sign makes for more consistent behaviour when passing arguments. #54

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

CompPhy
Copy link

@CompPhy CompPhy commented Nov 12, 2024

Fixes #53

Copy link
Member

@cmoulliard cmoulliard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The chart version is updated during the releasing process. So I don't think that it should be upgraded here.

@cmoulliard
Copy link
Member

I confirm that the version of the helm chart is well tagged when we release: https://github.com/snowdrop/godaddy-webhook/blob/main/.github/workflows/release.yml#L34C1-L42C93

@CompPhy

@cmoulliard cmoulliard merged commit 07df2af into snowdrop:main Nov 13, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken --v flag in release 0.4.0
2 participants