SNOW-1917265: Add OAUTH_TYPE for authorization flow #2174
+543
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michał Hofman <[email protected]>
sfc-gh-mmishchenko
requested changes
Feb 12, 2025
| @@ -436,3 +436,4 @@ class IterUnit(Enum): | |||
| ) | |||
|
|
|||
| _OAUTH_DEFAULT_SCOPE = "session:role:{role}" | |||
| _OAUTH_TYPE_AUTHORIZATION_CODE = "authorization_code" | |||
There was a problem hiding this comment.
In general a single leading underscore by conventions means 'internal' or 'protected', so we shouldn't use it here as we import it in another module
| @@ -19,3 +19,4 @@ def test_auth_oauth(): | |||
| auth.update_body(body) | |||
| assert body["data"]["TOKEN"] == token, body | |||
| assert body["data"]["AUTHENTICATOR"] == "OAUTH", body | |||
| assert body["data"]["OAUTH_TYPE"] == "authorization_code", body | |||
There was a problem hiding this comment.
This test is for the existing OAuth implementation, i.e. for authentication with a pre-obtained access token
sfc-gh-mmishchenko
force-pushed
the
mkeller/SNOW-1825621/oauth-code-flow-support
branch
from
f4827ef to
a850492
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1917265
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Add login body parameter with the type of OAuth used.
(Optional) PR for stored-proc connector: