Skip to content

Commit

Permalink
Ack failures too
Browse files Browse the repository at this point in the history
  • Loading branch information
colmsnowplow committed May 31, 2024
1 parent 93e84fe commit 07253e2
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion pkg/target/http.go
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,10 @@ func (ht *HTTPTarget) Write(messages []*models.Message) (*models.TargetWriteResu
}
} else {
errResult = multierror.Append(errResult, errors.New("Got response status: "+resp.Status))
// This stops retries for this demo.
// For the demo, ack failures too, because it's confusing when they re-appear.
if msg.AckFunc != nil {
msg.AckFunc()
}
failed = append(failed, msg)
continue
}
Expand Down

0 comments on commit 07253e2

Please sign in to comment.