Fix panic on failure target WriteOversized() and WriteInvalid() (closes

#194)
snowplow · Aug 22, 2022 · b1063e9 · b1063e9
1 parent df2008c
commit b1063e9
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/cmd/cli/cli.go b/cmd/cli/cli.go
@@ -220,6 +220,9 @@ func sourceWriteFunc(t targetiface.Target, ft failureiface.Failure, tr transform
 		if len(messagesToSend) > 0 {
 			err2 := retry.Exponential(5, time.Second, "failureTarget.WriteOversized", func() error {
 				res, err := ft.WriteOversized(t.MaximumAllowedMessageSizeBytes(), messagesToSend)
+				if err != nil {
+					return err
+				}
 				if len(res.Oversized) != 0 || len(res.Invalid) != 0 {
 					log.Fatal("Oversized message transformation resulted in new oversized / invalid messages")
 				}
@@ -238,6 +241,9 @@ func sourceWriteFunc(t targetiface.Target, ft failureiface.Failure, tr transform
 		if len(messagesToSend) > 0 {
 			err3 := retry.Exponential(5, time.Second, "failureTarget.WriteInvalid", func() error {
 				res, err := ft.WriteInvalid(messagesToSend)
+				if err != nil {
+					return err
+				}
 				if len(res.Oversized) != 0 || len(res.Invalid) != 0 {
 					log.Fatal("Invalid message transformation resulted in new invalid / oversized messages")
 				}