Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OAuth2 in HTTP target #325

Merged
merged 1 commit into from
May 24, 2024
Merged

Add support for OAuth2 in HTTP target #325

merged 1 commit into from
May 24, 2024

Conversation

pondzix
Copy link
Contributor

@pondzix pondzix commented May 23, 2024

Jira ref: PDP-1140

Inspired by official OAuth2 RFC and example API provided by Google Ads

@pondzix pondzix force-pushed the oauth2 branch 4 times, most recently from 8c1772f to 07c615f Compare May 23, 2024 09:22
Copy link
Collaborator

@colmsnowplow colmsnowplow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice and neeat!

Just had a quick skim so far but will find time to review properly!

Copy link
Collaborator

@colmsnowplow colmsnowplow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Piotr

@pondzix pondzix merged commit ac843a1 into develop May 24, 2024
1 check passed
@pondzix pondzix deleted the oauth2 branch May 24, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants