Add jq generic mapper transformation #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
| use "jq" { | ||
| jq_command = <<JQEOT | ||
| { | ||
| my_api_key: "${env.TESTAPIKEY}", |
There was a problem hiding this comment.
For our design, API keys wouldn't ever be expected to be handled here. Can we remove this from the example?
I think it might create a false expectation of how we expect things to be configured. :)
pkg/transform/mapper.go
Outdated
| // JQMapperConfig represents the configuration for the JQ transformation | ||
| type JQMapperConfig struct { | ||
| JQCommand string `hcl:"jq_command"` | ||
| RunTimeout int `hcl:"timeout_sec,optional"` |
There was a problem hiding this comment.
2 small nits on this:
- 1s is actually quite a long minimum possible timeout for this kind of feature. I'd expect it to be very fast - perhaps it should be in ms?
- Could we have the unit in the setting name? Just for QOL
colmsnowplow
approved these changes
Jun 18, 2024
adatzer
force-pushed
the
feat/jq_transformation_dev
branch
from
61776c3 to
e594770
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ref: PDP-1222
This PR supersedes #329