Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for chunking #336

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

colmsnowplow
Copy link
Collaborator

No description provided.

Copy link
Contributor

@adatzer adatzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -158,7 +158,7 @@ func TestRetrieveHeaders(t *testing.T) {
t.Run(tt.Name, func(t *testing.T) {
testTargetConfig := &HTTPTargetConfig{
HTTPURL: "http://test",
ByteLimit: 1048576,
RequestByteLimit: 1048576,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - MessageByteLimit

Copy link
Collaborator Author

@colmsnowplow colmsnowplow Jun 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Max messages isn't there either - I didn't update the tests yet, but there's a ticket for it. Just did enough here to allow tests for batched http requests (and fixing up the other tests, which also still fail for the moment!). :)

@colmsnowplow colmsnowplow merged commit 9971ec5 into feat/batch-templating Jun 20, 2024
1 check failed
@colmsnowplow colmsnowplow deleted the add-chunk-config branch June 20, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants