Factor approximate template size in when batching #348
+15
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adatzer
reviewed
Jul 2, 2024
| }, nil | ||
| } | ||
|
|
||
| func loadRequestTemplate(templateFile string) (*template.Template, error) { | ||
| func loadRequestTemplate(templateFile string) (int, *template.Template, error) { |
There was a problem hiding this comment.
Could we check and error in case the requestByteLimit or the messageByteLimit set by the user in config are less than the approxTmplSize? Probably means a user mistake, but in that cases all messages will count as oversized.
There was a problem hiding this comment.
Sure, pushed a change. Likely if their limit is that low it'll all be oversized regardless, but no harm in adding the check
Won't be exact but will err on the side of caution since the template file's data will be _slightly_ bigger than the empty template.
colmsnowplow
force-pushed
the
account-for-template-size
branch
from
8bab55a to
af5c378
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Won't be exact but will err on the side of caution since the template file's data will be slightly bigger than the empty template.