Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting Subject session information (closes #78) #79

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

jethron
Copy link
Contributor

@jethron jethron commented Aug 1, 2024

No description provided.

@snowplowcla snowplowcla added the cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed. label Aug 1, 2024
@coveralls
Copy link

coveralls commented Aug 1, 2024

Coverage Status

coverage: 99.464% (+0.01%) from 99.452%
when pulling 0242710 on jethron:session-info
into 88ca5cf on snowplow:master.

Copy link
Contributor

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

// SetNetworkUserId adds a network user id to the key-value store.
func (s Subject) SetNetworkUserId(networkUserId string) {
s.payload.Add(NETWORK_UID, common.NewString(networkUserId))
}

// FromIdCookie sets subject fields from the ID cookie to the key-value store.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch!

@jethron jethron changed the base branch from master to release/3.0.1 August 1, 2024 04:58
@jethron jethron changed the base branch from release/3.0.1 to master August 1, 2024 04:59
@matus-tomlein matus-tomlein changed the base branch from master to release/3.1.0 August 2, 2024 10:58
@matus-tomlein
Copy link
Contributor

Hi @jethron, sorry forgot about this one, but happy to make the release if you merge in the PR into the release branch.

@jethron
Copy link
Contributor Author

jethron commented Aug 12, 2024

Thanks @matus-tomlein; I don't actually have permissions on this repo to do the merge, are you able to?

@matus-tomlein matus-tomlein merged commit 0917f9e into snowplow:release/3.1.0 Aug 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants