Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integrated test for log rotation #309

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Add integrated test for log rotation #309

merged 1 commit into from
Feb 19, 2025

Conversation

jezen
Copy link
Collaborator

@jezen jezen commented Feb 19, 2025

This is the follow-up to this PR.

/cc @ulidtko @ktak-007

@jezen
Add integrated test for log rotation
08d18aa 
This is the follow-up to [this PR][0].

[0]: snoyberg#308
@jezen jezen requested a review from jappeace February 19, 2025 14:40
@jezen jezen mentioned this pull request Feb 19, 2025
Closed
jappeace
jappeace approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@jappeace jappeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice test suite 😆

@jezen
Copy link
Collaborator Author

jezen commented Feb 19, 2025

I'm happy with how this turned out. I'm able to run these NixOS VM tests on my MacOS machine with nix flake check -L.

I'm even able to run these interactively, like this:

nix run .#checks.x86_64-darwin.integratedTests.driverInteractive -- --interactive

Once the Python REPL is ready, you can run machine.shell_interact() to drop into a [somewhat janky] shell.

So cool!

@jezen jezen merged commit d7dffe6 into snoyberg:master Feb 19, 2025
9 checks passed
@jezen jezen deleted the integrated-test-for-rotate-logs-true branch February 19, 2025 15:33
ulidtko
ulidtko reviewed Feb 19, 2025
View reviewed changes
Copy link
Contributor

@ulidtko ulidtko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

This is actually pretty cool 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulidtko ulidtko ulidtko left review comments

@jappeace jappeace jappeace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jezen @ulidtko @jappeace