Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tutorial ml folder #52

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

update tutorial ml folder #52

wants to merge 6 commits into from

Conversation

trhieung
Copy link

No description provided.

Copy link
Owner

@snwagh snwagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a few comments. Given that there are significant changes, if you could add a good PR description, I can make a branch and merge your changes into that branch.

@@ -1 +1,2 @@
.DS_Store
./src/*.o
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some .o files in the commit, something like *.o might work.


RUN cd Falcon \
&& make all -j$(nproc)
RUN git clone https://github.com/trhieung/falcon-public Falcon
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're pushing these changes upstream, can you edit the repo address to link to https://github.com/snwagh/falcon-public.git.

@@ -0,0 +1,120 @@
# Hướng dẫn traning model với falcon
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rename the file with the language tutorial_<language_code>.md or even better, README_language.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants