Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add support for code test --report for native implementation #311

Merged
merged 6 commits into from
Feb 28, 2025

Conversation

PeterSchafer
Copy link
Contributor

@PeterSchafer PeterSchafer commented Feb 22, 2025

This PR adds support for snyk code test --report to the native implementation. It also introduces an additional feature flag to guard this logic, until the feature flag is enabled --report will still use the legacy implementation.

FeatureFlag:

  • local: INTERNAL_SNYK_CODE_IGNORES_REPORT_ENABLED
  • remote: snykCodeReportConsistentIgnores

In addition this PR

  • cleans up the old unused sarif renderer
  • refactors the datatransformation workflow to make transformation directly usable from inside the code workflow
  • extends response middleware to use response errors either JSON API or Error Catalog

@PeterSchafer PeterSchafer requested review from a team as code owners February 22, 2025 10:20
@PeterSchafer PeterSchafer force-pushed the cli-613-report branch 3 times, most recently from eda3ed9 to 396b2b7 Compare February 27, 2025 15:45
@PeterSchafer PeterSchafer changed the title chore: Ad support for code test --report for native implementation chore: Add support for code test --report for native implementation Feb 27, 2025
@PeterSchafer PeterSchafer force-pushed the cli-613-report branch 4 times, most recently from 959d2df to 4686fcd Compare February 27, 2025 22:24
@PeterSchafer PeterSchafer merged commit ae19bde into main Feb 28, 2025
9 checks passed
@PeterSchafer PeterSchafer deleted the cli-613-report branch February 28, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants