Feat: cleanup versions #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinygrasshopper
approved these changes
May 7, 2024
This param was never used upstream, however until recently it was required for historic reasons. We have now changed that so it is no longer required and thus superfluous. Not specifying it will improve compatibility with other OAuth2 libraries.
We shouldn't be setting an example of calling experimental endpoints, this endpoint is in GA so call that instead.
jgresty
force-pushed
the
feat/cleanup-versions
branch
from
6eb3923
to
c2e9ac9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove version from authorizationURL
This param was never used upstream, however until recently it was required for historic reasons. We have now changed that so it is no longer required and thus superfluous. Not specifying it will improve compatibility with other OAuth2 libraries.
call GA version of get /orgs endpoint
We shouldn't be setting an example of calling experimental endpoints, this endpoint is in GA so call that instead.