fix: use secret for artifactoryUrl #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-snyk
force-pushed
the
fix/artifactory-url-as-secret
branch
from
9cb27ce to
b682c5d
Compare
pavel-snyk
force-pushed
the
fix/artifactory-url-as-secret
branch
from
40fcda0 to
4fb70c3
Compare
saumilmac
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a secret if
scmType: artifactorybecause ARTIFACTORY_URL may containuser:passwordin URL as Basic auth.Following secrets will be created because they may contain credentials:
Additionally BROKER_CLIENT_URL will be set for consistency with other scmTypes.