fix: prevent npe and user-facing error when eclipse is loaded with no projects open [IDE-845] #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrobinsonhodges-snyk
changed the title
bastiandoetsch
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix to prevent user-facing error when eclipse is started with no projects open. Note that we still don't refresh plugins when a project is opened - I'll raise a separate ticket for that.
Description
Previously, if eclipse was opened without a project, the plugin would crash and the user would see a garbled view with no obvious way to recover. Now, the Snyk plugin loads correctly.
Checklist
Screenshots / GIFs
Before:
After:
