New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: summary panel [IDE-892] #253

Merged

acke merged 20 commits into main from feat/IDE-892_summary-panel

Jan 30, 2025

Contributor

acke commented Jan 18, 2025 •

edited

Loading

Description

Done:

New Summary Panel.
Notification listener $/snyk.scanSummary that receives HTML as a string from Snyk Language Server, and applies it to the summary panal.
functions for changing tabs, toggling between all issues and delta issues.
Apply styling to the HTML from Snyk Language Server.
Hook up new browser function to the HTML tabs from Snyk Language Server.
new BrowserFunction(browser, "enableDelta")
Delta base branch selection.
Update the getSummaryInitHtml().
Update styling for the HTML in the Summary Panel.

Checklist

Tests added and all succeed
Linted
CHANGELOG.md updated
README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

acke changed the title ~~Feat/ide 892 summary panel~~ feat: summary panel [IDE-892]

acke force-pushed the feat/IDE-892_summary-panel branch 2 times, most recently from 1652fd3 to 2d196bc Compare

January 20, 2025 13:14

acke marked this pull request as ready for review

January 28, 2025 11:30

acke requested a review from a team as a code owner

January 28, 2025 11:30

acke added the DO NOT MERGE label

Contributor

ShawkyZ commented Jan 28, 2025

Background color is a bit off

ShawkyZ approved these changes

View reviewed changes

bastiandoetsch reviewed

View reviewed changes

plugin/src/main/java/io/snyk/eclipse/plugin/html/StaticPageHtmlProvider.java Outdated Show resolved Hide resolved

bastiandoetsch reviewed

View reviewed changes

plugin/src/main/java/io/snyk/eclipse/plugin/html/StaticPageHtmlProvider.java Outdated Show resolved Hide resolved

bastiandoetsch reviewed

View reviewed changes

plugin/src/main/java/io/snyk/eclipse/plugin/html/StaticPageHtmlProvider.java Outdated Show resolved Hide resolved

bastiandoetsch reviewed

View reviewed changes

plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/SnykToolView.java Outdated Show resolved Hide resolved

bastiandoetsch reviewed

View reviewed changes

plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/SummaryBrowserHandler.java Outdated Show resolved Hide resolved

ShawkyZ reviewed

View reviewed changes

plugin/src/main/java/io/snyk/languageserver/protocolextension/SnykExtendedLanguageClient.java Outdated Show resolved Hide resolved

bastiandoetsch reviewed

View reviewed changes

plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/SummaryBrowserHandler.java Outdated Show resolved Hide resolved

github-advanced-security bot found potential problems

View reviewed changes

plugin/src/main/java/io/snyk/eclipse/plugin/html/BaseHtmlProvider.java Fixed Show fixed Hide fixed

plugin/src/main/java/io/snyk/eclipse/plugin/html/BaseHtmlProvider.java Fixed Show fixed Hide fixed

plugin/src/main/java/io/snyk/eclipse/plugin/html/StaticPageHtmlProvider.java Fixed Show fixed Hide fixed

plugin/src/main/java/io/snyk/eclipse/plugin/html/StaticPageHtmlProvider.java Fixed Show fixed Hide fixed

plugin/src/main/java/io/snyk/eclipse/plugin/html/StaticPageHtmlProvider.java Fixed Show fixed Hide fixed

plugin/src/main/java/io/snyk/languageserver/LsConstants.java Fixed Show fixed Hide fixed

plugin/src/main/java/io/snyk/languageserver/LsConstants.java Fixed Show fixed Hide fixed

acke removed the DO NOT MERGE label

acke and others added 13 commits

January 30, 2025 11:26


          wip: new summary panal

d8990d1

New layout with two browsers
$/snyk.scanSummary callback
Placeholders for all issues scan tab/delta scan


          fix: added a SummaryPanelParams

8d98fd8


          fix: fix scanSummary params

80d778a


          fix: enable/disable delta and Update configuration

99c2cc4


          fix: Add styling to the Snyk Language Server html

9d6f8e8


          fix: clean up code

9a4172a


          tidy: rename refreshSummary to updateSummary

06d8e04


          fix: syntax errror

826aad0


          fix: Added --ide-background-color and did formatting


          fix: hook up browswerfunctions for enable/disable delta

accd883


          fix: add initial html and fix styling

630c41c


          fix: refactor the browserFunctions to enableDelta

caa9223


          fix: refactor calls to the languageclient

6af38f8

acke added 3 commits

January 30, 2025 11:26


          fix: updated changelog

bb51b6a


          fix: Fix lint warnings

5ab3ae6


          fix: replace constants interface with a proper constants class for li…

44420b6

…nter

acke force-pushed the feat/IDE-892_summary-panel branch from 97d40cc to 44420b6 Compare

January 30, 2025 10:26

ShawkyZ requested changes

View reviewed changes

plugin/src/main/java/io/snyk/eclipse/plugin/html/StaticPageHtmlProvider.java Show resolved Hide resolved


          fix: add the replace for ideScript

716313d

ShawkyZ approved these changes

View reviewed changes

acke force-pushed the feat/IDE-892_summary-panel branch from adede5c to 5b278e8 Compare

January 30, 2025 14:20

github-advanced-security bot found potential problems

View reviewed changes

plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/ProductTreeNode.java Fixed Show fixed Hide fixed

plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/ProductTreeNode.java Fixed Show fixed Hide fixed


          tidy: fix linter warnings

fff3029

acke force-pushed the feat/IDE-892_summary-panel branch from dd93824 to fff3029 Compare

January 30, 2025 15:03


          fix: lint errors

befa9dd

github-advanced-security bot found potential problems

View reviewed changes

plugin/src/main/java/io/snyk/languageserver/protocolextension/SnykExtendedLanguageClient.java Outdated

		var cacheHashMap = issueCache.getCacheByDisplayProduct(productTreeNode.getProduct());
		ArrayList<Issue> issuesList = new ArrayList<>(); // Reusable ArrayList

Check warning

Code scanning / PMD

Avoid using implementation types like 'ArrayList'; use the interface instead

Avoid using implementation types like 'ArrayList'; use the interface instead

plugin/src/main/java/io/snyk/languageserver/protocolextension/SnykExtendedLanguageClient.java Fixed Show fixed Hide fixed

acke force-pushed the feat/IDE-892_summary-panel branch from 92102ca to 864ad64 Compare

January 30, 2025 15:35


          fix: lint errors

2147d0b

acke force-pushed the feat/IDE-892_summary-panel branch from 864ad64 to 2147d0b Compare

January 30, 2025 15:47

acke merged commit 440de46 into main

7 checks passed

acke deleted the feat/IDE-892_summary-panel branch

January 30, 2025 15:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet