Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update download script location #117

Merged
merged 1 commit into from
Jul 25, 2024
Merged

chore: update download script location #117

merged 1 commit into from
Jul 25, 2024

Conversation

j-luong
Copy link
Contributor

@j-luong j-luong commented Jul 24, 2024 •
edited
Loading

Can be tested once related CLI PR is merged
How to test:

  • from root directory (where Dockerfile is located)
  • run docker build . --tag <tagName> --build-arg="IMAGE=<imageName>" --build-arg="TAG=<tag>" --build-arg="CLI_VERSION=preview"
    • where imageName and tag can be any value from the build matrix in build.yml
  • run docker run --rm -it <tagName> bash
  • verify snyk version is the correct preview version using snyk -v

@j-luong j-luong requested a review from a team as a code owner July 24, 2024 13:32
@j-luong j-luong mentioned this pull request Jul 24, 2024
Merged
10 tasks
@PeterSchafer PeterSchafer merged commit 1694f14 into master Jul 25, 2024
62 checks passed
@PeterSchafer PeterSchafer deleted the chore/CLI-413_updateDownloadURL branch July 25, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandor-trombitas sandor-trombitas sandor-trombitas approved these changes

@PeterSchafer PeterSchafer PeterSchafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-luong @sandor-trombitas @PeterSchafer