Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Swift image #86

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Fix Swift image #86

merged 1 commit into from
Jan 29, 2024

Conversation

grahamburgsma
Copy link
Contributor

Fixes the Swift image by actually basing it on the Swift docker image rather than just alpine.

Related to snyk/actions#133.

@grahamburgsma grahamburgsma requested a review from a team as a code owner December 14, 2023 19:50
@CLAassistant
Copy link

CLAassistant commented Dec 14, 2023

CLA assistant check
All committers have signed the CLA.

@thisislawatts
Copy link
Member

Thanks for raising the PR @grahamburgsma, lets see if we can get this sorted out :)

@thisislawatts thisislawatts merged commit 4b230c9 into snyk:master Jan 29, 2024
3 checks passed
@grahamburgsma
Copy link
Contributor Author

Thanks @thisislawatts. Are you able to get snyk/actions#133 merged as well? I've tested and it works now that this one is merged.

@thisislawatts
Copy link
Member

thisislawatts commented Jan 30, 2024

Thanks for the follow up @grahamburgsma, I have not yet been able to verify the built image successfully tests a swift project. I would like to see this behaving correctly before updating the Actions repo.

Heres the command I would expect to see test results with:

$ docker run --rm -it --env SNYK_TOKEN --env DEBUG -v $(pwd):/app snyk/snyk:swift

@grahamburgsma
Copy link
Contributor Author

I would like to see this behaving correctly before updating the Actions repo.

@thisislawatts If this helps, here is the test I ran yesterday using my actions fork. The action includes a bunch of other inputs, but you can see it runs against snyk/snyk:swift.

Screenshot 2024-01-30 at 7 54 54 AM

@thisislawatts
Copy link
Member

Thanks for confirming @grahamburgsma, great to see this working. I have not yet had a successful test run when working directly with the image, this manual QA blocks further usage of this image being rolled out. Be sure that merging your changes to the actions repo is top of my list once the QA is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants