Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automated-region-configuration (IDE-732) #631

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

acke
Copy link
Contributor

@acke acke commented Oct 25, 2024

Description

If $/snyk.hasAuthenticated transmits an API URL, this is saved in the settings.

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@acke acke changed the title feat/automated-region-configuration (IDE-732) feat: automated-region-configuration (IDE-732) Oct 25, 2024
@bastiandoetsch bastiandoetsch marked this pull request as ready for review October 25, 2024 12:50
@bastiandoetsch bastiandoetsch requested a review from a team as a code owner October 25, 2024 12:50
@acke acke force-pushed the feat/IDE-731_automated-snyk-region-configuration branch from 70370d0 to d8456d4 Compare October 25, 2024 13:02
@acke acke merged commit 7ee680b into master Oct 25, 2024
9 checks passed
@acke acke deleted the feat/IDE-731_automated-snyk-region-configuration branch October 25, 2024 14:25
bastiandoetsch added a commit that referenced this pull request Nov 6, 2024
* feat: add plugin installed event

* feat: automated-region-configuration (IDE-732) (#631)

* feat: Automated Snyk region configuration (IDE-732)

* tidy: remove legacy functionality for domain/V1

* chore: update changelog

* feat: add plugin installed event

* chore: don't log actual filesystem path

* chore: add changelog, minor visibility change to private methods

* fix: test and visibility

---------

Co-authored-by: Knut Funkel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants