Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: address failures in CI pipeline #191

Merged
merged 8 commits into from
Apr 3, 2024
Merged

chore: address failures in CI pipeline #191

merged 8 commits into from
Apr 3, 2024

Conversation

thisislawatts
Copy link
Member

@thisislawatts thisislawatts commented Mar 4, 2024 •
edited
Loading

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

  • Updates state assertions in line with latest data. Ideally these tests should be more resilient to changing data state but that work is out of scope for the current task.
  • Updated GitHub action to more recent versions to remove deprecated warning in Action summary
  • Skip test directory as part of Snyk scans which was resulting in false positives
  • Skip consistently failing container test on Windows. Suspected cause is limited toolchain on windows image. Further investigation required, which is out of scope for the current task.
  • Mitigate https://app.snyk.io/vuln/SNYK-JAVA-ORGAPACHEMAVEN-6144614 by upgrading
    maven-core to 3.8.1.

@thisislawatts thisislawatts force-pushed the chore/validate-ci-pipelines branch from 5b7e18e to 5ec1690 Compare April 2, 2024 14:24
@thisislawatts thisislawatts force-pushed the chore/validate-ci-pipelines branch from a6d0b8f to 6d593fe Compare April 2, 2024 15:41
@thisislawatts thisislawatts force-pushed the chore/validate-ci-pipelines branch 2 times, most recently from 61fe7f5 to 3b12330 Compare April 2, 2024 17:35
@thisislawatts thisislawatts force-pushed the chore/validate-ci-pipelines branch from c0edea0 to 6fd3326 Compare April 2, 2024 19:08
@thisislawatts thisislawatts marked this pull request as ready for review April 2, 2024 19:36
@thisislawatts thisislawatts requested a review from a team as a code owner April 2, 2024 19:36
@thisislawatts thisislawatts changed the title chore: validate CI pipeline chore: address failures in CI pipeline Apr 2, 2024
@thisislawatts thisislawatts mentioned this pull request Apr 2, 2024
Closed
3 tasks
cmars
cmars approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@cmars cmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@thisislawatts thisislawatts merged commit 382c084 into main Apr 3, 2024
12 checks passed
@thisislawatts thisislawatts deleted the chore/validate-ci-pipelines branch April 3, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmars cmars cmars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thisislawatts @cmars