Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] - gha: limit nixos builds to master and manual #783

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

sarcasticadmin
Copy link
Member

@sarcasticadmin sarcasticadmin commented Sep 24, 2024

Description

Fixes: #781

Running these on every PR or every push to a PR quickly gets us rate limited by github. Its unclear if theres a way around this cache rate limit:
https://github.com/DeterminateSystems/magic-nix-cache-action?tab=readme-ov-file#usage-notes

Moving this to only running on master and manually should do the trick for now. If it persists we might have to move it to a scheduled job like openwrt builds.

Previous Behavior

  • Bumping up against gha cache limits for many PRs due to nixosConfiguration builds

New Behavior

  • ci-nixos only running on master and manually

Tests

  • gha for existing PR nix builds jobs
  • will confirm for ci-nixos jobs after they are merged to master

Running these on every PR or every push to a PR quickly gets us
rate limited by github. Its unclear if theres a way around this cache
rate limit:
https://github.com/DeterminateSystems/magic-nix-cache-action?tab=readme-ov-file#usage-notes

Moving this to only running on `master` and manually should do the trick
for now. If it persists we might have to move it to a scheduled job like
openwrt builds.
Copy link
Contributor

@djacu djacu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good compromise for now

@sarcasticadmin sarcasticadmin changed the title [REVIEW] - gha: limit nixos builds to master and manual [READY] - gha: limit nixos builds to master and manual Sep 26, 2024
@sarcasticadmin sarcasticadmin merged commit ef74408 into master Sep 27, 2024
2 checks passed
@sarcasticadmin sarcasticadmin deleted the rh/issue-781 branch September 27, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

substituter errors in CI (GH rate limit)
2 participants