Include cookie-related CORS config in passport-example #3864
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
Example works without problems, but implicitly relies on same-origin cookie sending behaviour which isn't always the case in real implementations.
New behavior
Makes the reliance on same-origin cookie behaviour explicit and add sample CORS configuration that while not strictly needed in the example, are useful when adapting the example to real world scenario. Makes the example a tad bit more "complete".
Other Info
Adding this is perhaps important because the configuration affects a library (
express-session
) that users may not directly work with, so may not have knowledge of correct configuration. Moreover, the library itself is centric toexpress
so it doesn't offersocket.io
configuration information, so this might be the best place to put this.