Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle nested params #86

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Properly handle nested params #86

wants to merge 1 commit into from

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Jun 2, 2022

#52

Types of Changes

  • Bug fix.
  • New feature.

Testing

  • I added tests for my changes.
  • I tested my changes locally.
  • I tested my changes in staging.
  • I tested my changes in production.

@ioquatix
Copy link
Member Author

ioquatix commented Jun 2, 2022

It turns out handling headers is a bit more complex. The part headers are indexed by key, but this won't work for nested parts, we either need:

  1. Nested part headers based on keys, computed during recursion, i.e. part_headers[k] - we'd also might need to ignore non-string-key headers when constructing parts.
  2. Flat part headers indexed by full key prefix/path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants