add support for drain event and send response boolean to make sockjs …

…compliant with Writeable api that allows for handling back pressure
sockjs · Nov 1, 2024 · efea906 · efea906
1 parent 0e8d891
commit efea906
Show file tree

Hide file tree

Showing 11 changed files with 940 additions and 1,075 deletions.
diff --git a/dist/sockjs-esm.js b/dist/sockjs-esm.js
diff --git a/dist/sockjs.js b/dist/sockjs.js
diff --git a/dist/sockjs.js.map b/dist/sockjs.js.map
diff --git a/dist/sockjs.min.js b/dist/sockjs.min.js
diff --git a/dist/sockjs.min.js.map b/dist/sockjs.min.js.map
diff --git a/lib/main.js b/lib/main.js
@@ -164,7 +164,7 @@ SockJS.prototype.send = function(data) {
   if (this.readyState !== SockJS.OPEN) {
     return;
   }
-  this._transport.send(escape.quote(data));
+  return this._transport.send(escape.quote(data));
 };
 
 SockJS.version = require('./version');

diff --git a/lib/transport/iframe.js b/lib/transport/iframe.js
@@ -128,6 +128,7 @@ IframeTransport.prototype.postMessage = function(type, data) {
 IframeTransport.prototype.send = function(message) {
   debug('send', message);
   this.postMessage('m', message);
+  return true;
 };
 
 IframeTransport.enabled = function() {

diff --git a/lib/transport/lib/buffered-sender.js b/lib/transport/lib/buffered-sender.js
@@ -25,6 +25,7 @@ BufferedSender.prototype.send = function(message) {
   if (!this.sendStop) {
     this.sendSchedule();
   }
+  return true;
 };
 
 // For polling transports in a situation when in the message callback,

diff --git a/lib/transport/websocket.js b/lib/transport/websocket.js
@@ -54,14 +54,17 @@ function WebSocketTransport(transUrl, ignore, options) {
     self.emit('close', 1006, 'WebSocket connection broken');
     self._cleanup();
   };
+  this.ws.on('drain', function() {
+    self.emit('drain');
+  })
 }
 
 inherits(WebSocketTransport, EventEmitter);
 
 WebSocketTransport.prototype.send = function(data) {
   var msg = '[' + data + ']';
   debug('send', msg);
-  this.ws.send(msg);
+  return this.ws.send(msg);
 };
 
 WebSocketTransport.prototype.close = function() {

diff --git a/lib/version.js b/lib/version.js
@@ -1 +1 @@
-module.exports = '1.6.2';
+module.exports = '0.0.3';
diff --git a/package.json b/package.json
@@ -1,13 +1,12 @@
 {
-  "name": "sockjs-client",
+  "name": "sockjs-client-testable",
   "description": "SockJS-client is a browser JavaScript library that provides a WebSocket-like object.",
-  "version": "1.6.2",
+  "version": "0.0.4",
   "author": "Bryce Kahle",
   "jsdelivr": "dist/sockjs.min.js",
   "engines": {
     "node": ">=12"
   },
-  "funding": "https://tidelift.com/funding/github/npm/sockjs-client",
   "browser": {
     "./lib/transport/driver/websocket.js": "./lib/transport/browser/websocket.js",
     "eventsource": "./lib/transport/browser/eventsource.js",
@@ -70,7 +69,7 @@
   "types": "./dist/sockjs.d.ts",
   "repository": {
     "type": "git",
-    "url": "https://github.com/sockjs/sockjs-client.git"
+    "url": "https://github.com/testable/sockjs-client.git"
   },
   "scripts": {
     "test": "mocha tests/node.js",
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		module.exports = '1.6.2';
		module.exports = '0.0.3';