Compatible with CompleteFuture asynchronous programming

[dajitui]

Motivation:

As shown in the following link, the Sofarpc part of the code is written based on an older version of jdk, which is not compatible with the usage of jdk8 CompleteFuture. In order to make the framework more compatible with asynchronous programming, I have modified the corresponding ResponseFuture content

#945 (comment)

Modification:

My idea is that ResponseFuture directly inherits CompleteFuture, as it already inherits Future and CompletionStage, and there is no need to implement classes to override these methods in the future

Result:

Fixes #.

[OrezzerO]

see why-should-text-files-end-with-a-newline

[dajitui]

woc，I heard about it for the first time

[OrezzerO]

Same problem.

[dajitui]

Do you know why unit testing is unstable? Sometimes through unit testing, occasionally with exceptions

[OrezzerO]

@EvenLjj We need to make our unit test stable. It is disgusting to try it again and again :( . How about add a task to solve it ?

[EvenLjj]

OK, some single tests require reconstruction, we will kick of.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad29f00) 72.01% compared to head (09a51f7) 72.06%.
Report is 30 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1323      +/-   ##
============================================
+ Coverage     72.01%   72.06%   +0.04%     
- Complexity      783      784       +1     
============================================
  Files           416      416              
  Lines         17659    17663       +4     
  Branches       2752     2752              
============================================
+ Hits          12718    12729      +11     
+ Misses         3538     3529       -9     
- Partials       1403     1405       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dajitui]

@OrezzerO @EvenLjj This merger request is a bit long, do you have time to help review it and merge branch?

[EvenLjj]

@OrezzerO @EvenLjj This merger request is a bit long, do you have time to help review it and merge branch?

OK, but this PR will also affect the internal version, and we will review in the next iteration and merge after passing the internal regression test.

[dajitui]

@OrezzerO @EvenLjj This merger request is a bit long, do you have time to help review it and merge branch?

OK, but this PR will also affect the internal version, and we will review in the next iteration and merge after passing the internal regression test.

OK, i get it

[OrezzerO]

 @Test
    public void thenApply() throws InterruptedException {
        AtomicBoolean applied = new AtomicBoolean(false);
        MyFuture myFuture = new MyFuture(1000);
        Consumer<? super String> consumer = (String str) -> {
            System.out.println(str);
            applied.compareAndSet(false, true);
        };
        myFuture.thenAccept(consumer);

        myFuture.setSuccess("done");

        Thread.sleep(1000);

        Assert.assertTrue(applied.get());

    }

    @Test
    public void thenApply_correctVersion() throws InterruptedException {
        AtomicBoolean applied = new AtomicBoolean(false);
        CountDownLatch countDownLatch = new CountDownLatch(1);
        CompletableFuture<String> future = CompletableFuture.supplyAsync(() -> {
            // 模拟耗时操作
            try {
                countDownLatch.await();
            } catch (InterruptedException e) {
                throw new RuntimeException(e);
            }
            return "Hello, World!";
        });

        Consumer<? super String> consumer = (String str) -> {
            System.out.println(str);
            applied.compareAndSet(false, true);
        };
        future.thenAccept(consumer);

        countDownLatch.countDown();

        Thread.sleep(1000);

        Assert.assertTrue(applied.get());

    }

I write two test case . The first one is aim to test AbstractResponseFuture, and the second one shows how CompletableFuture should work. Please make sure the first case can pass.

[dajitui]

 @Test
    public void thenApply() throws InterruptedException {
        AtomicBoolean applied = new AtomicBoolean(false);
        MyFuture myFuture = new MyFuture(1000);
        Consumer<? super String> consumer = (String str) -> {
            System.out.println(str);
            applied.compareAndSet(false, true);
        };
        myFuture.thenAccept(consumer);

        myFuture.setSuccess("done");

        Thread.sleep(1000);

        Assert.assertTrue(applied.get());

    }

    @Test
    public void thenApply_correctVersion() throws InterruptedException {
        AtomicBoolean applied = new AtomicBoolean(false);
        CountDownLatch countDownLatch = new CountDownLatch(1);
        CompletableFuture<String> future = CompletableFuture.supplyAsync(() -> {
            // 模拟耗时操作
            try {
                countDownLatch.await();
            } catch (InterruptedException e) {
                throw new RuntimeException(e);
            }
            return "Hello, World!";
        });

        Consumer<? super String> consumer = (String str) -> {
            System.out.println(str);
            applied.compareAndSet(false, true);
        };
        future.thenAccept(consumer);

        countDownLatch.countDown();

        Thread.sleep(1000);

        Assert.assertTrue(applied.get());

    }

I write two test case . The first one is aim to test AbstractResponseFuture, and the second one shows how CompletableFuture should work. Please make sure the first case can pass.

@Test
    public void thenApply() throws InterruptedException {
        AtomicBoolean applied = new AtomicBoolean(false);
        MyFuture myFuture = new MyFuture(1000);
        Consumer<? super String> consumer = (String str) -> {
            System.out.println(str);
            applied.compareAndSet(false, true);
        };
        myFuture.thenAccept(consumer);

        myFuture.setSuccess("done");

        boolean isDone = myFuture.complete("done");

        Thread.sleep(1000);

        Assert.assertTrue(applied.get());

    }

I found that future does not perform an operation, it needs to call complete method to modify the state @OrezzerO

[OrezzerO]

Yes, you are right. So there is a compatibility issues here. We need to make sure that when future task is complete, then it trigger 'then apply' task. complete method is provided by CompletableFuture , it will not invoked by sofarpc code. We need to invoke method such as complete in sofarpc some where.

[OrezzerO]

I think this pr is ok. @EvenLjj Please check compatibility with internal version .

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[dajitui]

@EvenLjj Buddy, this pr is a bit long and will be marked as expired. Evaluate whether the merger will affect the existing code, thanks

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.