forked from facebook/hermes
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static Hermes for React Native #3
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces necessary changes to let React Native uses latest version of static Hermes.
Explanation
Part 1
The
HERMES_IS_MOBILE_BUILD
flag is only set when theHERMES_IS_ANDROID
flag is active. However, these two have different roles. To correctly build for Android, I need the flexibility to set these flags separately. This is crucial because theHERMES_IS_MOBILE_BUILD
flag might lead to build failures if there are undeclared types being used - an issue we've already flagged to the Hermes team (I can create an issue with a description if you wants)Part 2
It seems like this flag doesn’t exist anymore in the MSVC 16 compiler.
CI logs - https://github.com/piaskowyk/react-native/actions/runs/11815096269/job/32915591004
Part 3
Some of the new syntax in static Hermes requires the newer C++ standard on MSVC.
Part 4
# Changes in lib/CMakeLists.txt
These updates are necessary to successfully build the Hermes Framework for iOS.
Part 5
Due to additional additional anonymous namespace, the MSVC wasn't able to recognise proper symbol without explicite definition.
Test Plan
Build RNTester app from here - https://github.com/piaskowyk/react-native/tree/%40piaskowyk/build-static-hermes