Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: AudioNode + AnalyserNode #273

Merged
merged 10 commits into from
Jan 28, 2025
Merged

Conversation

maciejmakowski2003
Copy link
Collaborator

@maciejmakowski2003 maciejmakowski2003 commented Jan 24, 2025

Closes #272

Introduced changes

  • Add AudioNode interface to docs
  • Add destination in disconnect as optional param

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code

Maciej Makowski and others added 5 commits January 24, 2025 20:48
* feat: added AnalyserNode to docs

* fix: fixed bolds

* feat: finished AnalyserNode docs

* fix: fixed example time-domian data size based on docs

---------

Co-authored-by: Maciej Makowski <[email protected]>
@michalsek michalsek changed the title Feat/docs/audio node Docs: AudioNode + AnalyserNode Jan 27, 2025
packages/audiodocs/docs/core/audio-node.mdx Outdated Show resolved Hide resolved
packages/audiodocs/docs/core/audio-node.mdx Outdated Show resolved Hide resolved
packages/audiodocs/docs/core/audio-node.mdx Outdated Show resolved Hide resolved
packages/audiodocs/docs/core/audio-node.mdx Outdated Show resolved Hide resolved
packages/audiodocs/docs/core/audio-node.mdx Outdated Show resolved Hide resolved
packages/audiodocs/docs/visualization/analyser-node.mdx Outdated Show resolved Hide resolved
packages/audiodocs/docs/visualization/analyser-node.mdx Outdated Show resolved Hide resolved
packages/audiodocs/docs/visualization/analyser-node.mdx Outdated Show resolved Hide resolved
packages/audiodocs/docs/visualization/analyser-node.mdx Outdated Show resolved Hide resolved
packages/audiodocs/docs/visualization/analyser-node.mdx Outdated Show resolved Hide resolved
Copy link
Member

@michalsek michalsek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, looks clean and easy to read or to find something! 🎉

@maciejmakowski2003 maciejmakowski2003 merged commit b58ba39 into main Jan 28, 2025
11 checks passed
@maciejmakowski2003 maciejmakowski2003 deleted the feat/docs/audio-node branch January 28, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor and check all AudioNode methods
2 participants