Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/general context refactoring #276

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Refactor/general context refactoring #276

merged 4 commits into from
Jan 30, 2025

Conversation

maciejmakowski2003
Copy link
Collaborator

Closes #264

Introduced changes

  • Moved AudioPlayer property to AudioContext
  • Refactored renderAudio function calling by AudioPlayer. Currently renderAudio renders maximum RENDER_QUANTUM_SIZE of frames, so most of AudioPlayer audio requests consist of more then one call of renderAudio.

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code

@maciejmakowski2003 maciejmakowski2003 self-assigned this Jan 30, 2025
@maciejmakowski2003 maciejmakowski2003 marked this pull request as ready for review January 30, 2025 11:39
@maciejmakowski2003 maciejmakowski2003 merged commit 59a8293 into main Jan 30, 2025
11 checks passed
@maciejmakowski2003 maciejmakowski2003 deleted the refactor/general-context-refactoring branch January 30, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsek michalsek michalsek approved these changes

Assignees

@maciejmakowski2003 maciejmakowski2003

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider setting constant render quantum size
2 participants
@maciejmakowski2003 @michalsek