Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/constants and types #278

Merged
merged 22 commits into from
Jan 31, 2025
Merged

Refactor/constants and types #278

merged 22 commits into from
Jan 31, 2025

Conversation

maciejmakowski2003
Copy link
Collaborator

@maciejmakowski2003 maciejmakowski2003 commented Jan 31, 2025 •
edited
Loading

Closes #262
Closes #263

Introduced changes

  • Refactored types based on below rules:

    • time connected variables are of type double
    • audio data variables are of type float
    • audio arrays/buses' size/indices are of type 'size_t`
    • smaller sizes are of type int

  • Refactored core's constants management

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code

Maciej Makowski added 22 commits January 31, 2025 08:10
refactor: refactored types and constants in AudioArray
6f19220
refactor: refactored types and constants in AnalyserNode
ca49f3c
refactor: refactored types and constants in AudioBus
cc910f8
fix: added necessary include
8783afc
refactor: refactored types and constants in AudioBuffer
5fd125b
refactor: refactored types and constants in AudioBufferSourceNode
215d253
refactor: refactored types and constants in BaseAudioContext
0e5d5f6
refactor: refactored types and constants in AudioContext
bcb2b7a
refactor: refactored types and constants in AudioDecoder and AudioDes…
9540536 
…tinationNode
refactor: refactored types and constants in AudioNode
d73abf5
refactor: refactored types and constants in AudioNodeManager
3d8b69f
refactor: refactored types and constants in AudioParam
b81a4ae
refactor: refactored types and constants in AudioScheduledSourceNode
9a0a14c
refactor: refactored types and constants in BiquadFilterNode
e651299
refactor: refactored types and constants in GainNode
c602830
refactor: refactored types and constants in OscillatorNode
3d0c0f2
refactor: refactored types and constants in StereoPannerNode
ae6861d
refactor: refactored types and constants in PeriodicWave
4cd9168
refactor: refactored types in utils
fd5239b
ci: yarn format
672aa57
fix: fixed analyser types
7dd0b56
refactor: host objects
0fdd0e6
@maciejmakowski2003 maciejmakowski2003 marked this pull request as ready for review January 31, 2025 12:53
@maciejmakowski2003 maciejmakowski2003 self-assigned this Jan 31, 2025
michalsek
michalsek approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@michalsek michalsek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 🔥

@maciejmakowski2003 maciejmakowski2003 merged commit 147e724 into main Jan 31, 2025
10 checks passed
@maciejmakowski2003 maciejmakowski2003 deleted the refactor/constants-and-types branch January 31, 2025 14:13
@maciejmakowski2003 maciejmakowski2003 restored the refactor/constants-and-types branch January 31, 2025 14:25
@maciejmakowski2003 maciejmakowski2003 deleted the refactor/constants-and-types branch January 31, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsek michalsek michalsek approved these changes

Assignees

@maciejmakowski2003 maciejmakowski2003

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace int with size_t in cpp Fix constants management in cpp
2 participants
@maciejmakowski2003 @michalsek