Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $idx builder method to bindGroupLayouts #533

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mhawryluk
Copy link
Collaborator

closes #523

  • doesn't do anything yet
  • isn't generated by tgpu-gen (also yet)

Copy link
Collaborator

@iwoplaza iwoplaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥑🥑🥑

Comment on lines +139 to +141
/**
* Marks a bind group layout to appear with a specific group index in the resulting WGSL code
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit, we might be able to rephrase this to also note on the automatic indexing if the method is not called.

Suggested change
/**
* Marks a bind group layout to appear with a specific group index in the resulting WGSL code
*/
/**
* Associates this bind group layout with an explicit numeric index. When a call to this
* method is omitted, a unique numeric index is assigned to it automatically.
*
* Used when generating WGSL code: `@group(${index}) @binding(...) ...;`
*/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add $idx builder method to bindGroupLayouts.
2 participants