Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle externals in values of object expressions #884

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

iwoplaza
Copy link
Collaborator

No description provided.

Copy link

codesandbox-ci bot commented Feb 16, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

github-actions bot commented Feb 16, 2025

pkg.pr.new

packages

pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@884
pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@d76b19644329f6d818b1ab53b076c0c471feb287

benchmark
view benchmark

commit
view commit

@iwoplaza iwoplaza linked an issue Feb 16, 2025 that may be closed by this pull request
Copy link
Collaborator

@mhawryluk mhawryluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okiee

@iwoplaza iwoplaza force-pushed the fix/handle-externals-in-obj branch from d274b68 to d76b196 Compare February 17, 2025 12:45
@iwoplaza iwoplaza merged commit 82f8106 into main Feb 17, 2025
7 checks passed
@iwoplaza iwoplaza deleted the fix/handle-externals-in-obj branch February 17, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any external identifier used in object expressions is ignored.
2 participants